-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to lavalink's new YouTube audio source manager #1552
Switch to lavalink's new YouTube audio source manager #1552
Conversation
5c21773
to
422deed
Compare
This change makes it so that you are required to use the full YouTube playlist link rather than just the playlist ID. If your local playlist txt files are still using just the ID, they will not work anymore; you have to add https://youtube.com/playlist?list= to the front of the ID. |
I have asked the lavalink devs about that issue just now. They very graciously & rapidly provided a fix for this! I've updated the dependency to its latest version again. |
LGTM! Not a Java-pro or alike, so I can not contribute much - except say that the previously mentioned fork does indeed work. |
The lavalink devs seem to be separating the YouTube audio source manager into its own library: https://github.com/lavalink-devs/youtube-source. The new source manager seems to be more resilient against YouTube playback breaking.
This PR:
AudioSourceManagers.registerRemoteSources(this);
call and instead registers each audio source manager lavaplayer provides individually, EXCEPT for the YouTube one