Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to lavalink's new YouTube audio source manager #1552

Merged
merged 6 commits into from
May 10, 2024

Conversation

MichailiK
Copy link
Collaborator

@MichailiK MichailiK commented Apr 22, 2024

The lavalink devs seem to be separating the YouTube audio source manager into its own library: https://github.com/lavalink-devs/youtube-source. The new source manager seems to be more resilient against YouTube playback breaking.

This PR:

  • switches to this new audio source manager
  • removes the AudioSourceManagers.registerRemoteSources(this); call and instead registers each audio source manager lavaplayer provides individually, EXCEPT for the YouTube one
    • looking at lavaplayer's code, it doesn't look like you can exclude specific source managers, so to exclude the lavaplayer's built-in YouTube source manager, we have to register each source manager individually :/
  • reverts to a stable version of lavaplayer
  • gets rid of the logback filter we made to hide the "no google account provided thus cant play age restricted videos" log message, as its not present in that source manager.

@MichailiK MichailiK added this to the 0.4.1 milestone Apr 22, 2024
@MichailiK MichailiK force-pushed the new-youtube-lavaplayer-source branch from 5c21773 to 422deed Compare April 22, 2024 21:13
@MichailiK MichailiK changed the title Switch to new lavalink's new YouTube audio source manager Switch to lavalink's new YouTube audio source manager Apr 22, 2024
@ALocked1
Copy link

This change makes it so that you are required to use the full YouTube playlist link rather than just the playlist ID. If your local playlist txt files are still using just the ID, they will not work anymore; you have to add https://youtube.com/playlist?list= to the front of the ID.
image

@MichailiK
Copy link
Collaborator Author

I have asked the lavalink devs about that issue just now. They very graciously & rapidly provided a fix for this! I've updated the dependency to its latest version again.

@IngwiePhoenix
Copy link

LGTM!

Not a Java-pro or alike, so I can not contribute much - except say that the previously mentioned fork does indeed work.
Whwn can we expect a merge?

@jagrosh jagrosh merged commit 0afb3db into jagrosh:master May 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants