Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix window system scoping #1430

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix window system scoping #1430

wants to merge 4 commits into from
+10 −34

Conversation

Infiziert90
Copy link
Contributor

@Infiziert90 Infiziert90 commented Sep 24, 2023 •
edited
Loading

Changes how the Namespace is applied for WindowSystem, instead of PushID to uses a combined string which is used in Begin()

The resulting Window ID: WindowName##WindowSystem
Original: PushID WindowSystem -> PushID Window -> Begin(WindowName)

  • Strips any starting # from the namespace
  • Required parameter for WindowSystem
  • Removes it from Window

@Infiziert90 Infiziert90 requested a review from a team as a code owner September 24, 2023 19:46
@MidoriKami
Copy link
Contributor

MidoriKami commented Sep 24, 2023 •
edited
Loading

https://github.com/Infiziert90/Dalamud/blob/Namespace-Fix/Dalamud/Interface/Internal/Windows/ChangelogWindow.cs#L46

This line either needs to be removed, or the namespace added to the window name itself.

It's probably fine if it is simply removed(?)

@KazWolfe KazWolfe added enhancement New feature or request core Dalamud core labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@goaaats goaaats

Labels
core Dalamud core enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Infiziert90 @MidoriKami @KazWolfe @goaaats