Support XDG user directories #5333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 25, 2024 16:23
This can be used to receive configuration for "well known" directories
directly from the user. In our case, only the music directory really
matters. It's possible to implement some kind of caching system here so
that the same file doesn't get cached multiple times, but it's only used
from a single location ('beets.Library.__init__'), so it doesn't seem to
be really necessary.
Fixes beetbox#5168. Beets will now look for a music directory as follows: 1. Configuration in 'config.yaml'. 2. On Unix-like systems, 'XDG_MUSIC_DIR' in 'user-dirs.dirs'. 3. The fallback '~/Music'.
This allows testing the lookup and parsing stages independently.
I'm not great at writing tests, but this is a good start.
|
I don't love writing (example-based) tests, so there aren't many right now. If you'd like to see some more, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5168. A simple parser for
user-dirs.dirshas been implemented, and it is used to change the default music directory path whenbeets.Libraryis initialized.To Do
Documentation