Move concurrency settings to top-level #4257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibraheemdev
approved these changes
Jun 14, 2024
charliermarsh
force-pushed
the
charlie/context
branch
2 times, most recently
from
f9eb785
to
f672a88
Compare
charliermarsh
force-pushed
the
charlie/context
branch
from
f672a88
to
9a25c44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These are global and non-specific to the
pipAPI, so I think they should be elevated.Test Plan
UV_CONCURRENT_DOWNLOADS=1 cargo run pip list; verified thatdownloadsresolved to 1.concurrent-downloads = 5under[tool.uv]inpyproject.toml; rancargo run pip list; verified thatdownloadsresolved to 5.UV_CONCURRENT_DOWNLOADS=1 cargo run pip list; verified thatdownloadsresolved to 1.