Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hypervisor in Logfile outputs #92

Merged
merged 6 commits into from
May 15, 2024
Merged

Conversation

hakushiii
Copy link

@hakushiii hakushiii commented Mar 18, 2024

Easier checking for hypervisor status in macOS logfiles without opening the logfile itself.

  • Adds Hypervisor to logfile returns
  • If in macOS -> Enabled / Disabled | If not in macOS -> not Applicable

@hakushiii hakushiii changed the title Add hypervisor in Logfile return outputs Add hypervisor in Logfile outputs Mar 18, 2024
@hakushiii
Copy link
Author

Ran ryujinx_log_analyzer manually to check JSON outputs. Here are the test outputs:

@hakushiii hakushiii marked this pull request as ready for review March 23, 2024 07:56
@TSRBerry TSRBerry self-requested a review March 28, 2024 15:46
Copy link
Member

@TSRBerry TSRBerry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you! Sorry for the late review.

I added a commit to change "Not applicable" to "N/A" to save space in the embed and another one to actually include the hypervisor setting in the embed for discord.

@TSRBerry TSRBerry merged commit 41bc653 into Ryujinx:master May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants