Enable NuGetAuditSuppress for packages.config CLI restore
#5875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
approved these changes
Jul 2, 2024
nkolev92
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/2691
Regression? Last working version:
Description
Enables
NuGetAuditSuppressfor packages.config CLI restore (msbuild, static graph restore, nuget.exe).AuditChecker.cs- core logicNuGet.targets- enable collection of NuGetAuditSuppress itemsAuditCheckResult.cs- telemetrytest/- unit tests and func testsNuGetAuditSuppress PackageReference CLI restore PR: #5679
NOTE: nuget.exe restore using a packages.config file does not work since it does not currently pick up any of the
NuGetAuditsettings from the project file (includingNuGetAuditandNuGetAuditLevel). Audit still runs, but it uses default settings.PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation