Apply SPIRV-Cross workarounds for Metal bugs #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billhollings
requested changes
Jun 7, 2024
Yes, it was already included, that's why there's no SPIRV-Cross update needed |
2 workarounds introduced: - Fragments with side effects will now execute following Vulkan - Depth/Stencil write postponed to post fragment execution when input attachment and depth/stencil attachment reference the same resource
aitor-lunarg
force-pushed
the
apply-spirv-workarounds
branch
from
8242fd9
to
190e993
Compare
|
Sorry for the delay on the update. I believe all comments should have been addressed. I will provide a follow up PR to handle the dynamic rendering case, mainly because it'll require bigger changes, and wanted to keep this PR small. If there's something I missed, do let me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 workarounds introduced:
Fixes #2232
Fixes #2233