Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everyday it logs me out #41

Closed
aierwin opened this issue May 18, 2022 · 26 comments
Closed

Everyday it logs me out #41

aierwin opened this issue May 18, 2022 · 26 comments
Labels
bug Something isn't working unconfirmed bug A bug report that needs triaging

Comments

@aierwin
Copy link

aierwin commented May 18, 2022

each time I come back to the bot to type /store im logged out again even though I never typed logout

@staciax
Copy link
Owner

staciax commented May 19, 2022

Where do you host the bot?

@aierwin
Copy link
Author

aierwin commented May 19, 2022

ubuntu server 20.04LTS linode VPS

@staciax
Copy link
Owner

staciax commented May 19, 2022

when /login can /store without username, password

@aierwin
Copy link
Author

aierwin commented May 19, 2022

sorry?

@staciax
Copy link
Owner

staciax commented May 19, 2022

image

@aierwin
Copy link
Author

aierwin commented May 19, 2022

I understand this and it works I can continuously type /store and it will work but sometimes (a lot) it randomly logs me out and I have to retype /login

@staciax
Copy link
Owner

staciax commented May 20, 2022

I think the refresh cookie function might be problematic.

@staciax staciax added bug Something isn't working unconfirmed bug A bug report that needs triaging and removed bug Something isn't working labels May 20, 2022
@staciax staciax pinned this issue May 20, 2022
@mangunan
Copy link

Me too, so tired of login everyday with 2fa :(

@staciax staciax added the bug Something isn't working label May 20, 2022
@staciax
Copy link
Owner

staciax commented May 20, 2022

Okay, it's really a bug.
Thank you for informing me.

@staciax
Copy link
Owner

staciax commented May 20, 2022

Cookies for users who use 2fa are different from those who turn off 2fa.

The bug comes from the cookie refresh function.
It has some cookies missing. For users who open 2fa

staciax added a commit that referenced this issue May 20, 2022
@staciax
Copy link
Owner

staciax commented May 20, 2022

I won't close this issue until I'm sure. that it's not a bug anymore, thank you :)

@staciax
Copy link
Owner

staciax commented May 20, 2022

image

@mangunan
Copy link

The problem still persist

@mangunan
Copy link

IMG_20220522_134529

@staciax
Copy link
Owner

staciax commented May 22, 2022

When was the last time you used the /store command?

Is your account 2FA enabled right?

@aierwin
Copy link
Author

aierwin commented May 22, 2022

Just now and it looks like it logged me out again. Yes my account has 2fa enabled

@staciax
Copy link
Owner

staciax commented May 22, 2022

cookies with 2FA enabled, it will be different from a 2FA disabled.

I'll try the update again. :)
thanks you

staciax added a commit that referenced this issue May 22, 2022
#41
remember =  True
rememberDevice = True

# coommands
/notify add - add check user in db

# error_handler
remove traceback print
@staciax
Copy link
Owner

staciax commented May 22, 2022

i'm updated SHA-4d0572

@aierwin
Copy link
Author

aierwin commented May 24, 2022

ok I updated my files and from what I can tell it works thanks

@aierwin aierwin closed this as completed May 24, 2022
@staciax
Copy link
Owner

staciax commented May 24, 2022

you're welcome

@luqmanghost18
Copy link

luqmanghost18 commented May 24, 2022

For now, this issue is still occur for me everyday

@staciax
Copy link
Owner

staciax commented May 24, 2022

For now, this issue is still occur for me everyday

Where do you host the bot?

@luqmanghost18
Copy link

For now, this issue is still occur for me everyday

Where do you host the bot?

at heroku

@staciax
Copy link
Owner

staciax commented May 25, 2022

For now, this issue is still occur for me everyday

Where do you host the bot?

at heroku

heroku will reset user data every 24, this is normal for free dyno plans.

@luqmanghost18
Copy link

For now, this issue is still occur for me everyday

Where do you host the bot?

at heroku

heroku will reset user data every 24, this is normal for free dyno plans.

okay thank you

@staciax
Copy link
Owner

staciax commented May 25, 2022

you're welcome

shumm7 pushed a commit to shumm7/Valorant-DiscordBot that referenced this issue Sep 6, 2022
shumm7 pushed a commit to shumm7/Valorant-DiscordBot that referenced this issue Sep 6, 2022
staciax#41
remember =  True
rememberDevice = True

# coommands
/notify add - add check user in db

# error_handler
remove traceback print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed bug A bug report that needs triaging
Projects
None yet
Development

No branches or pull requests

4 participants