When Viewing PR, Show "[username] has started a review" to all users, not just [username] #4427
Replies: 6 comments
-
This is driving me absolutely crazy and I've been bitten by this so many times. I often spend an hour on a review, and nobody knows that I have started one. The worst problem is that it's easy to forget to submit the review, then none of your comments are visible to anyone else. I would very much like to have a timeline event that says "some-user has started a review" with a button or checkbox for "show pending comments". This simple change would prevent a lot of friction in my team's current code review process. Edit: sorry, I don't know how to submit a comment instead of an answer. |
Beta Was this translation helpful? Give feedback.
-
Running into this recently (and I'm pretty sure this won't be the last time) - I commented something and didn't even realized that I have to submit it to make it visible to others. This "Pending" badge is not helping - what is pending? I thought it means pending action for the review, only later that I discovered that it means my comments are not yet submitted. And no. If I have to read through your PR review docs to know I have to submit review before it's visible to others, the UI leaves much to be desired. |
Beta Was this translation helpful? Give feedback.
-
This would be a great feature. I've run into the same issues discussed in the the main request and the additional comment as both PR initiator and as reviewer. |
Beta Was this translation helpful? Give feedback.
-
I just ran into this issue, it was my first time reviewing a code and didn't even notice the |
Beta Was this translation helpful? Give feedback.
-
This is a big one for me. Has anyone looked into this feature request? |
Beta Was this translation helpful? Give feedback.
-
That would be a very useful information. There were multiple times where I was reviewing a PR and the author merged it because someone else already approved it. Our team has an agreement where we post a message to Slack with a request to review the PR and whoever starts reviewing marks the message with a specific emoji. This approach has many drawbacks, someone might forget to mark the message or just ignores it because it's tedious. Having that information displayed in the PR timeline would be so much better. |
Beta Was this translation helpful? Give feedback.
-
I noticed recently that when you start a review on another user's pull request, the reviewer will see a mention that they have started a review.
![BPL-1976__SRP_Signup_by_peteigel_·Pull_Request__436·_isubscribed_chief-wiggum](https://user-images.githubusercontent.com/1998134/123968137-f8528480-d984-11eb-81e6-4a67d8cd4f22.png)
Example:
Currently this is only viewable by the reviewer and not other members of the team. I think this would be useful if everyone with access to the PR could see that a review has been started.
There are two main use cases I can see:
The first use case is as a reviewer. This could help to reduce duplication of effort. If you come to review a PR and see that other team members are already actively reviewing that PR, you could move on to another PR that maybe no one has looked at yet.
The second use case is as the author of the PR. If I have an open PR that has been approved. If I could see that another team member has started a review, but not finished it yet, I could be courteous to them and reach out to ask if they plan to finish it or should I just merge. The other team member could have gotten sidetracked and has valuable feedback tucked away in a pending review that currently only the reviewer knows exists.
Thanks for any consideration you give this request.
Beta Was this translation helpful? Give feedback.
All reactions