Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate sampler lod bias #2163

Open
aitor-lunarg opened this issue Feb 21, 2024 · 1 comment
Open

Emulate sampler lod bias #2163

aitor-lunarg opened this issue Feb 21, 2024 · 1 comment
Labels
Bug CTS Issue causes a failure of one or more CTS tests

Comments

@aitor-lunarg
Copy link
Collaborator

#2142 tries to tackle this issue exposing internal Metal SPIs. Unfortunately, even with MVK_USE_METAL_PRIVATE_API enabled, there are still CTS tests failing in the M3 chip family. Proposed solution is to emulate as pointed out in #2142 (comment)

Failing CTS tests:

dEQP-VK.pipeline.monolithic.sampler.max_sampler_lod_bias.sampler_bias
@aitor-lunarg
Copy link
Collaborator Author

aitor-lunarg commented Jun 7, 2024

I think it would be beneficial to rework how samplers are passed to Metal so that we pass the following data per sampler:

  • sampler
  • bias
  • border_color

Then modify the shader to add bias (since bias is implemented in shader for Metal) and handle opaque black and as a nice side effect support custom border color (unsure if MoltenVK has support for this, I think not).

Refer to KhronosGroup/Vulkan-Portability#37 (comment) for the custom border color.

Mentioning this because it could be a unified effort to support bias and border color since both require similar changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CTS Issue causes a failure of one or more CTS tests
Projects
None yet
Development

No branches or pull requests

2 participants